Allow for passing in additional order fields #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for the caller to add notBefore/notAfter for servers that support them, or the "replaces" field which is added in draft-ietf-acme-ari-04 for servers that support ARI. (Again, not sure if there might be a better approach.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the caller to add notBefore/notAfter for servers that support them, or the "replaces" field which is added in draft-ietf-acme-ari for servers that support ARI.
(Again, not sure if there might be a better approach. I'm pretty sure all supported versions of node support the way I used the spread operator, but it may be that one want to copy the fields a different way, or explicitly list which fields one wants to allow the caller to specify.)