Handle case where the returned auth is already valid #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least for Buypass, if one already has previously validated an authorization on that ACME account for a requested domain name, the initial status when created is "valid". However, the code was trying to submit the challenge for validation anyway, causing the server to return "status:400 Unable to process challenge, authorization is not pending". So, if the initial status is valid, it should just proceed rather than trying to process the challenge again. I'm not sure if this is exactly the best way to write this, but it seems to work for me on both Let's Encrypt and Buypass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for Buypass, if one already has previously validated an authorization on that ACME account for a requested domain name, the initial status when created is "valid". However, the code was trying to submit the challenge for validation anyway, causing the server to return
status:400 Unable to process challenge, authorization is not pending. So, if the initial status is valid, it should just proceed directly rather than trying to process the challenge again.I'm not sure if this is exactly the best way to write this, but it seems to work for me on both Let's Encrypt and Buypass.