Daylight saving fix #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therefromhere
force-pushed
the
daylight_saving_fix
branch
from
57e7509 to
55f5960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I was hitting a bug in my date calculation (fixed before refactor as db10f5e), but I'm not sure I am now.
Astral now uses the same logic as db10f5e for calculation of current date, and my logs seem to be showing it calculating the correct times today.
But I think possibly either the Sure server is also adjusting curfew times, or the app is?
I think I had the bug where the day after the clocks change it calculates the wrong curfews, but can't reproduce now. Notification from 3:30am NZ time says "18:18 and 07:06", but my API logs at the same time say 19:18 & 07:06 ??
Clocks changed 2am -> 3am