Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifetime Annotations and Inference #314

Merged
merged 166 commits into from
Sep 3, 2023
Merged

Lifetime Annotations and Inference #314

merged 166 commits into from
Sep 3, 2023

Conversation

thepowersgang
Copy link
Owner

Although the branch is called borrowcheck - this is just the first half of a borrow checker.

Includes:

  • Storage and use of lifetime parameters through all compilation phases.
  • Lifetime elision rules
  • Lifetime inference - hecking of function inputs and outputs, required for closures to have lifetime annotations
  • Lots of improvements to promotion of borrows of constants.

@thepowersgang
All - Lifetime propagation, elision, and inference (incomplete)
cc74b94
@thepowersgang
Merge branch 'master' into borrowcheck (includes integration changes)
858cd23 
# Conflicts:
#	src/hir_expand/static_borrow_constants.cpp
@thepowersgang
Merge branch 'master' into borrowcheck
bc0b28c
@thepowersgang
HIR Static Borrow Constants - Always support ZSTs, better generic han…
8db00f1 
…dling, fix bad merge
@thepowersgang
Span - Improved span printing
3ff0ba4
@thepowersgang
HIR Static Borrow Constants - Fix ZST detection, special-case zero-co…
310e0e4 
…unt arrays
@thepowersgang
Lifetime Infer - Better reporting of mismatches
7dda588
@thepowersgang
Static trait resolve - Properly acquire trait lifetime params
f27dd61
@thepowersgang
AST - Improve handling of trait Foo : 'static (so it can be hackily…
d0792d5 
… used in lifetime inferrence)
@thepowersgang
main - Suppress debug for lifetime inference path
d57de21
@thepowersgang
HIR Static Borrow Constants - Correct result type when it's generic.
06addc4
@thepowersgang
HIR Expand Closures - Handle lifetimes in argument/return types
ecf9e36
@thepowersgang
HIR Expand Lifetime Infer - Handle struct/enum constructors as functi…
76bb5fd 
…on pointers
@thepowersgang
HIR From AST - Handle non-type params in enum item paths.
eba6002
@thepowersgang
HIR Lifetime Elision - Expand omitted lifetime parameters
e8a7fa3
@thepowersgang
HIR Serialise - Save trait path HRLs
39bdfef
@thepowersgang
HIR Typecheck - Slightly better handling of HRLs
3af1b4f
@thepowersgang
HIR Static Borrow Constants - Allow const functions
7460b62
@thepowersgang
HIR Lifetime Infer - Support _Emplace and pointer coercions.
53d6d67
@thepowersgang
HIR Lifetimes - Lots of little fixes, up to libstd 1.54
e65de0e
@thepowersgang
HIR Lifetimes - Proper un-elision of trait object lifetimes, trait ob…
2ce0c96 
…ject call, fix VTables
@thepowersgang
(broken typecheck) HIR - Move HRLs to GenericPath
e0725c8
@thepowersgang
HIR Lifetimes - Implement handling of Unsize
9a3612f
@thepowersgang
HIR Lifetimes - Another elision rule
23b1d8c
@thepowersgang
HIR - Compare HRLs when comparing paths (treat empty HRL as no HRLs)
fa0b009
@thepowersgang
Notes - More ideas on HRLs/HRTBs
503a748
@thepowersgang
(minor) HIR/MIR - Nicer error/debug messages
e41a623
@thepowersgang
HIR Typecheck - Remove some places where lifetime generics (and value…
6ffcc47 
… generics) can be lost
@thepowersgang
HIR - Fix printing of TraitPaths with only lifetimes
7eeebfb
@thepowersgang
HIR Typecheck - Expand HRLs in function bounds to empty lifetimes
2fb46bb
@thepowersgang
MIR Check - Run EAT on static types
84936da
@thepowersgang
HIR Typecheck Outer - Don't use default visitor for expressions (avoi…
656a454 
…ds visiting locals)
@thepowersgang
github actions - Yet another attempt at msbuild
53a1562
@thepowersgang
HIR Typecheck Outer - Copy type lifetimes from trait
267c732
@thepowersgang
HIR Lifetimes - Inherit lifetime bounds through types
e732dc1
@thepowersgang
github actions - Maybe this will work for msbuild
3ed3721
@thepowersgang
HIR Lifetime Elision - Tweak rules for trait objects outside of expre…
4ea9e16 
…ssions/arguments.
@thepowersgang
github actions - Almost there on msbuild
0033222
@thepowersgang
github actions - msbuild tweak again
29581a9
@thepowersgang
HIR Lifetime Elision - Don't use StaticTraitResolve as that needs t…
35f5d8b 
…rait aliases expanded.
@thepowersgang
HIR Dump - Tweak rendering of statics
cc36647
@thepowersgang
github actions - msbuild again
6101202
@thepowersgang
Trans Enumerate - Handle lifetime-generic statics
0be3a04
@thepowersgang
github actions msbuild - Fix output directory for artefacts
2b9afac
@thepowersgang
HIR Resolve Static - Check closure bodies for imut
615f754
@thepowersgang
HIR Expand SBC - Remove warnings for non-const
6aef981
@thepowersgang
HIR Expand Closures - Pick even more bounds, 1.54.0 compiles once more!
fcfb608
@thepowersgang
github actions msbuild - Fix 7z extraction
5136600
@thepowersgang
github actions msbuild - Fix bad yaml
53581ac
@thepowersgang
github actions msbuild - Fix rustc source download
b362b94
@thepowersgang
github actions msbuild - Include zlib in artefacts
22f5ad9
@thepowersgang
Notes - Add some random notes I had lying around
253be3a
@thepowersgang
Merge remote-tracking branch 'remotes/origin/master' into borrowcheck
505a11e 
# Conflicts:
#	rustc-1.29.0-src.patch
#	src/ast/ast.hpp
#	src/hir/expr.cpp
#	src/hir_typeck/monomorph.hpp
#	src/trans/auto_impls.cpp
#	tools/mir_opt_test/tests/misc_issues.rs
@thepowersgang
minipatch - Refactor patching tool to fix an error in offset calculat…
68fe3c6 
…ion.
@thepowersgang
Trans Codegen C - Work around a MSVC quirk with float literals
37ee215
@thepowersgang
github actions msbuild - Load environment for C compilation
e9e0ee4
@thepowersgang
Copy link
Owner Author

Looks like an important patch was clobbered in the merge from master, waiting for full regression test with fixed patch.

@thepowersgang
Copy link
Owner Author

Full regression run passes!

@thepowersgang thepowersgang merged commit 5af6405 into master Sep 3, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thepowersgang