Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix targets for Darwin PowerPC #302

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

barracuda156
Copy link
Contributor

See: #300 (comment)

@thepowersgang Could you please check this?

P. S. As I mention in the topic, Darwin on ppc32 may need 4-byte bools, since Apple ABI defines that: http://personal.denison.edu/~bressoud/cs281-s07/MacOSXLowLevelABI.pdf
Not sure if that should apply to Rust code though.

@thepowersgang
Copy link
Owner

Seems reasonable, although - do you want to wait until the PPC support is working?

@barracuda156
Copy link
Contributor Author

@thepowersgang I think this can be merged, as long as we are okay with targets (IMO they are correct), since mrustc itself builds and runs, what is broken is upstream rust, which can be fixed separately. Having ppc targets fixed may also be helpful in a case someone else will join the endeavor to fix rust for ppc, FWIW.
But of course this is up to you to decide.

@thepowersgang thepowersgang merged commit b4503ee into thepowersgang:master Apr 14, 2023
@barracuda156 barracuda156 deleted the darwin branch April 14, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants