Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support #1454

Merged
merged 11 commits into from
Oct 27, 2024
Merged

Add PHP 8.4 support #1454

merged 11 commits into from
Oct 27, 2024

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Oct 11, 2024

This is based on PR #1440 by @cedric-anne - Thank you Cédric!

This PR also replaces laminas/laminas-diactoros with nyholm/psr7 that supports PHP 8.4
This PR also bumps some dev dependencies for PHP 8.4 tests to pass.

Fixes #1450

@hafezdivandari hafezdivandari marked this pull request as ready for review October 11, 2024 19:22
Copy link
Contributor

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cedric-anne cedric-anne mentioned this pull request Oct 14, 2024
@hafezdivandari hafezdivandari mentioned this pull request Oct 15, 2024
8 tasks
@Sephster
Copy link
Member

Thank you @hafezdivandari and @cedric-anne for your work on this!

@Sephster Sephster merged commit 9e4f261 into thephpleague:master Oct 27, 2024
19 checks passed
@hafezdivandari hafezdivandari deleted the php84 branch October 28, 2024 00:23
@crynobone
Copy link

@Sephster Can we have this release ASAP (as PHP 8.4 has been released)

@Sephster
Copy link
Member

It hasn't yet. I will monitor and tag as soon as it is. I believe there is confusion here as the release has been tagged but my understanding is this does not equate to a release

@Sephster
Copy link
Member

Has now been released so I'll get this out today 👍

@hafezdivandari
Copy link
Contributor Author

@Sephster Laravel Passport 12.x (current stable) supports oauth2-server 8.x, so we should eighter backport this PR for 8.x (#1459) or review /merge #1410 and #1420 to be able to release Passport 13.x with oauth2-server 9.x

@crynobone
Copy link

CleanShot 2024-11-21 at 20 24 40

This PR doesn't belong to any release. We can check it from the commit page.

As an example, the following commit is available in 9.0.1

CleanShot 2024-11-21 at 20 25 54

@crynobone
Copy link

@hafezdivandari Can we have v9 working on Passport 12?

@hafezdivandari
Copy link
Contributor Author

hafezdivandari commented Nov 21, 2024

@crynobone No, because there are many BC breaking changes due to type declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supports PHP 8.4
4 participants