Use league/uri for true URI validation #1274
Merged
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a bit more elegant than #1237 - though that does include some test coverage for URIs, so we should include that here too. Speaking of tests, it doesn't appear the failures on this PR seem to be related to my changes... but I'll have to dig deeper. |
Spomky
reviewed
Mar 16, 2022
|
Tests are failing wth Doesn't feel related to this change but the test setup. |
|
No this is an ongoing issue I've not bothered to resolve as will be fixed in the next major. Happy to ignore it. Sorry for any confusion there |
|
Thanks @bradjones1 - this looks great and I'm embarrassed to say it didn't occur to me to use this library. Great find and thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1273