Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR-14 Event Dispatcher #1184

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

PSR-14 Event Dispatcher #1184

wants to merge 10 commits into from

Conversation

eugene-borovov
Copy link
Contributor

This PR inspired of #1168 and #1145.

  • Low coupling with league/event.
  • Events have individual object type.
  • Event objects enriched by contextual data.
  • Code of examples was updated. Now it contain Event Dispatcher usage.

derrabus
derrabus suggested changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Switching to PSR-14 would certainly help with integrating this library into frameworks that already provide a PSR-14 event dispatcher.

src/Events/EventDispatchableInterface.php Outdated Show resolved Hide resolved
src/Events/EventDispatchableTrait.php Outdated Show resolved Hide resolved
src/Events/EventDispatchableInterface.php Outdated Show resolved Hide resolved
src/Events/EventDispatchableTrait.php Outdated Show resolved Hide resolved
@eugene-borovov
Install PSR-14 Event Dispatcher
8b55917 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Declare domain events
2fd0f82 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Declare EventDispatchable interface
cc7548d 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Using EventDispatchable instead of EmitterAwareInterface
1065a8d 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Remove league/event dependency
fb905d3 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Added examples of using events
caa2e00 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Rename EventDispatchable to EventDispatcherAware
6eecb6d 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
The dispatchEvent method removed from EventDispatcherAwareInterface
21accbc 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Fix code style
3de6f68 
Signed-off-by: Eugene Borovov <[email protected]>
@eugene-borovov
Resolve conflict
27ff32f
@halfpastfouram halfpastfouram mentioned this pull request Jul 28, 2021
Closed
@Sephster Sephster mentioned this pull request May 12, 2022
Open
@TomHAnderson
Copy link

What's the hold-up on this PR and PSR-14? I'm using the league/event 3.0 in my GraphQL library https://github.com/API-Skeletons/doctrine-graphql but can't use this League library in tandem.

@MilesChou MilesChou mentioned this pull request Apr 19, 2023
Closed
@stof
Copy link

stof commented Aug 23, 2024

@Sephster is there any chance to get this merged ? It would make things a lot easier for frameworks (for instance, symfony/event-dispatcher implements the PSR-14 interface so the bundle could drop its current adapter layer forwarding events to the Symfony EventDispatcher)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eugene-borovov @TomHAnderson @stof @derrabus