add PSR15/PSR-17 compliant middleware #1029
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the delay on looking at this @datapp. I'm planning on merging this in later today although I will likely move the middleware into its own PSR folder instead of including PSR in the name. Many thanks for your efforts with this! |
|
This branch has not been merged yet. Could you merge it please @Sephster ? |
|
Sorry I completely forgot about this. I'm focusing on the Device Auth Grant at the moment but will pick this up as soon as I can. |
|
bump :-) |
|
bump, please - this looks good 👍 |
|
any updates on this? |
eugene-borovov
suggested changes
Jul 22, 2021
| public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface | ||
| { | ||
| try { | ||
| $response = $this->server->respondToAccessTokenRequest($request, $this->responseFactory->createResponse()); |
There was a problem hiding this comment.
You should return the response here
| } | ||
|
|
||
| // Pass the request on to the next responder in the chain | ||
| return $handler->handle($request); |
There was a problem hiding this comment.
This statement is unreachable.
| $requestHandlerMock | ||
| ); | ||
|
|
||
| $this->assertEquals(200, $response->getStatusCode()); |
There was a problem hiding this comment.
Add tests for the body of the response. Now it is empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves issue #942