-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Introduce a meta job for the tests #166
Open
theofidry
wants to merge
6
commits into
thephpleague:master
Choose a base branch
from
theofidry:ci/meta-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a04f7b7 - Browse repository at this point
Copy the full SHA a04f7b7View commit details -
ci: Introduce a meta job for the tests
When adding GitHub protection rules for a job, one needs to select the jobs based on the name, for example here "coding standards / coding standards". However, for jobs that are issued from a matrix, like here the unit test, one needs to add "unit tests / PHP 8.1 - Symfony 5.4.* - Composer --prefer-stable", "unit tests / PHP 8.2 - Symfony 5.4.* - Composer --prefer-stable" and co. manually. This is both tedious to add and to keep up to date as any change in the matrix result in this rule to be outdated. This PR introduces a very simple solution: have a meta job that passes if and only if all of the unit tests passes. This way we can have a rule for this job instead, which has a fixed label.
Configuration menu - View commit details
-
Copy full SHA for 053c611 - Browse repository at this point
Copy the full SHA 053c611View commit details
Commits on Oct 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 64a0919 - Browse repository at this point
Copy the full SHA 64a0919View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94e4e11 - Browse repository at this point
Copy the full SHA 94e4e11View commit details
Commits on Oct 16, 2023
-
Merge pull request thephpleague#163 from theofidry/chore/bamarni-depr…
…ecration chore: Fix Bamarni plugin deprecations
Configuration menu - View commit details
-
Copy full SHA for d6a3173 - Browse repository at this point
Copy the full SHA d6a3173View commit details
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 579e861 - Browse repository at this point
Copy the full SHA 579e861View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.