Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order of converting user #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix order of converting user #147

wants to merge 1 commit into from

Commits on Jun 12, 2023

  1. Fix order of converting user 

    Only convert the user from Symfony to League when no response is set on
the event. As conversion doesn't / shouldn't have any side effects and
the AuthorizationRequest isn't stored either (when a response is set)
this should be safe.
This helps in those cases where no user is logged in / resolved, but one
of the listeners sets a redirect. Otherwise the converter will be called
with a null value and has to return a proper value (can't be null) for
no obvious reason except to satisfy the interface.
    @RobertMe
    RobertMe committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    7ac897c View commit details
    Browse the repository at this point in the history