Generate keys commands #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone approve the workflows so I can get feedback from the whole matrix? |
|
My apologies for the delay Fabien, my OSS time was very limited lately I totally forgot to get back on this PR. |
|
ping @fbourigault @chalasr I think this still is a valuable addition, any updates on this? |
fbourigault
commented
Apr 4, 2024
|
I've rebased this PR and applied changes from LexikJWTAuthenticationBundle. |
|
@fbourigault Apologies for the delay here. I'm wiling to move forward :) Can you please have a look at failing tests? |
|
It took time, but here we go, this is in now. Thank you very much @fbourigault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my proposal to implement #106.
The first commit is an import of the command and the test from
LexikJWTAuthenticationBundleto make review of change easier.To do
$algorithma command option asLeagueOAuth2ServerBundledoesn't have such configuration option.