hasExpired() should use self::getTimeNow() #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 190 190
===========================================
Files 20 20
Lines 514 514
===========================================
Hits 514 514
|
ramsey
reviewed
Apr 16, 2023
| @@ -196,7 +196,7 @@ public function hasExpired() | |||
| throw new RuntimeException('"expires" is not set on the token'); | |||
| } | |||
|
|
|||
| return $expires < time(); | |||
| return $expires < self::getTimeNow(); | |||
There was a problem hiding this comment.
Should this be $this->getTimeNow(), since getTimeNow() is an instance method and not a static method?
There was a problem hiding this comment.
Oh, I missed that—probably because the accompanying setTimeNow() and resetTimeNow() are static methods.
Maybe getTimeNow() should be a static method too instead? It does not reference any instance-specific properties, only self::timeNow, or time() if self::timeNow is not set, so I can't see a good reason to have it as an instance method.
I have done that in my local development repo, and all tests are still passing. Will commit if I get a thumb up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to test some code that caches an AccessToken and refreshes it if it has expired, I discovered that AccessToken->hasExpired() uses time() instead of self::getTimeNow(), and thus ignores self::$timeNow when testing.
This pull request fixes that.