Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests by returning array from PSR7's ResponseInterface::getHeader() #1026

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix tests by returning array from PSR7's ResponseInterface::getHeader() #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6301772
PSR7 ResponseInterface::getHeader returns array
KorvinSzanto Feb 15, 2024
b614ea7
Remove typo
KorvinSzanto Feb 15, 2024
caade89
Replace more getHeader calls
KorvinSzanto Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/src/Grant/GrantTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function testGetAccessToken($grant, array $params = [])
->shouldReceive('getHeader')
->once()
->with('content-type')
->andReturn('application/json');
->andReturn(['application/json']);

/** @var ClientInterface & MockInterface $client */
$client = Mockery::spy(ClientInterface::class)->makePartial();
Expand Down
18 changes: 9 additions & 9 deletions test/src/Provider/AbstractProviderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ public function testGetUserProperties($name = null, $email = null, $id = null)
->shouldReceive('getHeader')
->once()
->with('content-type')
->andReturn('application/json');
->andReturn(['application/json']);


$client = Mockery::spy(ClientInterface::class, [
Expand Down Expand Up @@ -262,7 +262,7 @@ public function testGetUserPropertiesThrowsExceptionWhenNonJsonResponseIsReceive
$response
->shouldReceive('getHeader')
->with('content-type')
->andReturn('text/html');
->andReturn(['text/html']);

$client = Mockery::mock(ClientInterface::class, [
'send' => $response,
Expand Down Expand Up @@ -378,7 +378,7 @@ public function testPkceMethod($pkceMethod, $pkceCode, $expectedChallenge)
->shouldReceive('getHeader')
->once()
->with('content-type')
->andReturn('application/json');
->andReturn(['application/json']);

$client = Mockery::spy(ClientInterface::class, [
'send' => $response,
Expand Down Expand Up @@ -474,7 +474,7 @@ public function testErrorResponsesCanBeCustomizedAtTheProvider()
->shouldReceive('getHeader')
->once()
->with('content-type')
->andReturn('application/json');
->andReturn(['application/json']);

$client = Mockery::spy(ClientInterface::class, [
'send' => $response,
Expand Down Expand Up @@ -532,7 +532,7 @@ public function testClientErrorTriggersProviderException()
$response
->shouldReceive('getHeader')
->with('content-type')
->andReturn('application/json');
->andReturn(['application/json']);

$client = Mockery::mock(ClientInterface::class);
$client
Expand Down Expand Up @@ -579,7 +579,7 @@ public function testAuthenticatedRequestAndResponse()
$response
->shouldReceive('getHeader')
->with('content-type')
->andReturn('application/json');
->andReturn(['application/json']);

$client = Mockery::mock(ClientInterface::class);
$client
Expand Down Expand Up @@ -647,7 +647,7 @@ public function testGetAccessToken($method)
->shouldReceive('getHeader')
->once()
->with('content-type')
->andReturn('application/json');
->andReturn(['application/json']);

$client = Mockery::spy(ClientInterface::class, [
'send' => $response,
Expand Down Expand Up @@ -686,7 +686,7 @@ public function testGetAccessTokenWithNonJsonResponse()
$response
->shouldReceive('getHeader')
->with('content-type')
->andReturn('text/plain');
->andReturn(['text/plain']);

$client = Mockery::mock(ClientInterface::class, [
'send' => $response,
Expand Down Expand Up @@ -745,7 +745,7 @@ public function testParseResponse($body, $type, $parsed, $statusCode = 200)
$response
->shouldReceive('getHeader')
->with('content-type')
->andReturn($type);
->andReturn([$type]);

$method = $this->getMethod(AbstractProvider::class, 'parseResponse');
$result = $method->invoke($this->getMockProvider(), $response);
Expand Down
Loading