Fix encoding of generated query strings

Plus signs should not be encoded as spaces, as this will mangle the values during server processing. Fixes #605
thephpleague · Feb 1, 2017 · 0fae187 · 0fae187
1 parent 3859d43
commit 0fae187
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/Tool/QueryBuilderTrait.php b/src/Tool/QueryBuilderTrait.php
@@ -28,6 +28,6 @@ trait QueryBuilderTrait
      */
     protected function buildQueryString(array $params)
     {
-        return http_build_query($params, null, '&');
+        return http_build_query($params, null, '&', \PHP_QUERY_RFC3986);
     }
 }
diff --git a/test/src/Tool/QueryBuilderTraitTest.php b/test/src/Tool/QueryBuilderTraitTest.php
@@ -19,10 +19,11 @@ public function testBuildQueryString()
         $params = [
             'a' => 'foo',
             'b' => 'bar',
+            'c' => '+',
         ];
 
         $query = $this->buildQueryString($params);
 
-        $this->assertSame('a=foo&b=bar', $query);
+        $this->assertSame('a=foo&b=bar&c=%2B', $query);
     }
 }