Flysystem v2 #300
Closed
Flysystem v2 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Jan 19, 2021
Nitpick-CI
reviewed
Jan 19, 2021
Nitpick-CI
reviewed
Jan 19, 2021
Nitpick-CI
reviewed
Jan 19, 2021
Nitpick-CI
reviewed
Jan 19, 2021
Nitpick-CI
reviewed
Jan 19, 2021
Nitpick-CI
reviewed
Jan 19, 2021
Nitpick-CI
reviewed
Jan 19, 2021
ADmad
reviewed
Jan 19, 2021
| */ | ||
| public function setCache(FilesystemInterface $cache) | ||
| public function setCache($cache) |
There was a problem hiding this comment.
While the chances of someone extending the Server class are quite low, changing the signature of a public method is a BC break as per semver.
Closed
|
Closing as as discussed, we'll create a release focused on Flysystem 2 support (#301) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative approach to Flysystem v2 integration based on discussion in #291.
For now it's just a draft as none of the tests are refactored to handle new interfaces. Before touching them I'd love to hear opinions about code changes. I had no idea for better
ResponseFactoryInterface, open to suggestions.One important thing I might have missed some place is exception handling - Flysystem v2 changed a lot and now throws exceptions instead of returning
false. I've tried to adapt to it, but probably missed a place or two.And question about tests - how to proceed? Shall I detect available Flysystem version and check against available interfaces or write new tests for Flysystem v2 and skip those unavailable? Or maybe some other way? I think checking available interfaces is the way to go as we can then set up CI jobs to test against different Flysystem versions, but I might be wrong.