Implement serialize prevention. #803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twistor
force-pushed
the
safe-storage-serialize
branch
from
bf4ae9c
to
a5feef1
Compare
|
I would argue that |
twistor
force-pushed
the
safe-storage-serialize
branch
from
a5feef1
to
009ab40
Compare
twistor
force-pushed
the
safe-storage-serialize
branch
from
009ab40
to
285cf72
Compare
|
@twistor I'm thinking of closing this one. While it protects some, I think this should be the user's responsibility. Agree? |
|
That's fine with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from thephpleague/flysystem-sftp#36.
I've moved the actual data storage into a function static, that should help to ensure that it doesn't get serialized. I'm also not sure if class statics leak.
Edit: Added some tests to ensure behavior.