Add decorated adapter abstract class #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the old trait https://github.com/thephpleague/flysystem-adapter-decorator.
When working on my own adapters a bit, I was creating a sort of decorated adapter and was looking for way to reduce the boilerplate involved. I ran into the old trait, but found it was no longer up-to-date. Then I created an abstract base class of my own to achieve basically the same. Given that it might be useful to others and also can be used here for the
ReadOnlyadapter, I decided to create this PR.Note: I'm not sure if there's enough interest in merging this and maintaining it here, given the old trait also looks discontinued. Feel free to close if it's not useful enough, then this can just be here as a reference for people looking into this.