Return null instead of throwing, and added test

Co-Authored-By: Frank de Jonge <[email protected]>
thephpleague · Dec 29, 2019 · e19666c · e19666c
1 parent 7baf659
commit e19666c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/Util.php b/src/Util.php
@@ -267,14 +267,14 @@ public static function isSeekableStream($resource)
      *
      * @param resource $resource
      *
-     * @return int stream size
+     * @return int|null stream size
      */
     public static function getStreamSize($resource)
     {
         $stat = fstat($resource);
 
         if ( ! is_array($stat) || ! isset($stat['size'])) {
-            throw new RuntimeException('Cannot stat resource. Remote files are not supported.');
+            return null;
         }
 
         return $stat['size'];

diff --git a/tests/UtilTests.php b/tests/UtilTests.php
@@ -170,6 +170,13 @@ public function testStreamSize()
         fclose($stream);
     }
 
+    public function testStreamSizeForUrl()
+    {
+        $stream = \fopen('https://flysystem.thephpleague.com/img/flysystem.svg', 'r');
+        $this->assertNull(Util::getStreamSize($stream));
+        fclose($stream);
+    }
+
     public function testRewindStream()
     {
         $stream = tmpfile();