bug fix DROP_NEW_LINE can be removed with setFlags

thephpleague · Mar 23, 2015 · eae1c42 · eae1c42
1 parent 6bab6be
commit eae1c42
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,12 @@
 #Changelog
 All Notable changes to `League\Csv` will be documented in this file
 
+## 7.0.1 - 2015-03-XX
+
+### Fixed
+
+- `setFlags`: `SplFileObject::DROP_NEW_LINE` can be remove using `setFlags` method.
+
 ## 7.0.0 - 2015-02-19
 
 ### Added

diff --git a/src/Config/Controls.php b/src/Config/Controls.php
@@ -221,7 +221,7 @@ public function setFlags($flags)
             throw new InvalidArgumentException('you should use a `SplFileObject` Constant');
         }
 
-        $this->flags = $flags|SplFileObject::READ_CSV|SplFileObject::DROP_NEW_LINE;
+        $this->flags = $flags|SplFileObject::READ_CSV;
 
         return $this;
     }

diff --git a/test/ControlsTest.php b/test/ControlsTest.php
@@ -178,7 +178,6 @@ public function testSetFlags()
         $this->csv->setFlags(SplFileObject::SKIP_EMPTY);
         $this->assertSame(SplFileObject::SKIP_EMPTY, $this->csv->getFlags() & SplFileObject::SKIP_EMPTY);
         $this->assertSame(SplFileObject::READ_CSV, $this->csv->getFlags() & SplFileObject::READ_CSV);
-        $this->assertSame(SplFileObject::DROP_NEW_LINE, $this->csv->getFlags() & SplFileObject::DROP_NEW_LINE);
 
         $this->csv->setFlags(-3);
     }