bug fix BOM stripping #184

thephpleague · Oct 3, 2016 · d1b540d · d1b540d
1 parent 3b22a40
commit d1b540d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,24 @@
 
 All Notable changes to `Csv` will be documented in this file
 
+## Next
+
+### Added
+
+- None
+
+### Deprecated
+
+- None
+
+### Fixed
+
+- BOM filtering fix [issue #184](ttps://github.com/thephpleague/csv/issues/184)
+
+### Removed
+
+- None
+
 ## 8.1.1 - 2016-09-05
 
 ### Added

diff --git a/src/Modifier/QueryFilter.php b/src/Modifier/QueryFilter.php
@@ -222,7 +222,7 @@ protected function getStripBomIterator(Iterator $iterator)
             }
 
             $row[0] = mb_substr($row[0], $bom_length);
-            if ($row[0][0] === $enclosure && mb_substr($row[0], -1, 1) === $enclosure) {
+            if (mb_substr($row[0], 0, 1) === $enclosure && mb_substr($row[0], -1, 1) === $enclosure) {
                 $row[0] = mb_substr($row[0], 1, -1);
             }
 

diff --git a/test/ReaderTest.php b/test/ReaderTest.php
@@ -395,7 +395,6 @@ public function testEach()
         $transform = [];
         $this->csv->addFilter(function ($row) {
             return $row != [null];
-
         });
         $res = $this->csv->each(function ($row) use (&$transform) {
             $transform[] = array_map('strtoupper', $row);