setFlushThreshold method fix (#290)

thephpleague · Mar 26, 2018 · b9a4d39 · b9a4d39
1 parent fa94758
commit b9a4d39
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Writer.php b/src/Writer.php
@@ -265,7 +265,7 @@ public function setFlushThreshold($threshold): self
             throw new TypeError(sprintf(__METHOD__.'() expects 1 Argument to be null or an integer %s given', gettype($threshold)));
         }
 
-        if (null !== $threshold && 1 >= $threshold) {
+        if (null !== $threshold && 1 > $threshold) {
             throw new Exception(__METHOD__.'() expects 1 Argument to be null or a valid integer greater or equal to 1');
         }
 

diff --git a/tests/WriterTest.php b/tests/WriterTest.php
@@ -40,10 +40,17 @@ public function tearDown()
      */
     public function testflushThreshold()
     {
-        $this->expectException(Exception::class);
         $this->csv->setFlushThreshold(12);
         $this->assertSame(12, $this->csv->getFlushThreshold());
-        $this->csv->setFlushThreshold(12);
+    }
+
+    /**
+     * @covers ::setFlushThreshold
+     */
+    public function testflushThresholdThrowsException()
+    {
+        $this->csv->setFlushThreshold(1);
+        $this->expectException(Exception::class);
         $this->csv->setFlushThreshold(0);
     }