Improve JSONConverter codebase

thephpleague · Oct 10, 2024 · 9789b05 · 9789b05
1 parent b4583da
commit 9789b05
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/JsonConverter.php b/src/JsonConverter.php
@@ -416,7 +416,7 @@ public function convert(iterable $records): Iterator
         $buffer = [];
         while ($records->valid()) {
             if ($incr === $this->chunkSize) {
-                yield $this->format($buffer, $offset).$separator;
+                yield $this->format($buffer, $offset - $incr).$separator;
 
                 $incr = 0;
                 $buffer = [];
@@ -429,9 +429,8 @@ public function convert(iterable $records): Iterator
             $records->next();
         }
 
-        $last = $this->format($buffer, $offset);
-        if ('' !== $last) {
-            yield $last.$separator;
+        if ([] !== $buffer) {
+            yield $this->format($buffer, $offset - $incr).$separator;
         }
 
         yield $this->format([$current], $offset++).$end;