Skip to content

Commit

Permalink
Remove PHP8.3 skipped tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nyamsprod committed Feb 5, 2024
1 parent d697430 commit 91dc8ff
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 14 deletions.
10 changes: 5 additions & 5 deletions docs/9.0/reader/statement.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,8 +138,8 @@ $constraints = Statement::create()
->select('Integer', 'Text', 'Date and Time')
->where(fn (array $record): bool => (float) $record['Float'] < 1.3)
->orderBy(fn (array $r1, array $r2): int => (int) $r2['Integer'] <=> (int) $r1['Integer'])
->limit(5)
->offset(2);
->offset(2)
->limit(5);

$document = <<<CSV
Integer,Float,Text,Multiline Text,Date and Time
Expand All @@ -154,11 +154,11 @@ CSV;
$csv = Reader::createFromString($document);
$csv->setHeaderOffset(0);
$records = $constraints->process($csv);
//returns a ResultSet containing records which validates all the constraints.
//returns a ResultSet containing records which validate all the constraints.
```

Since the `Statement` instance is created independent of the CSV document you can re-use it on different CSV
document or `TabularDataReader` instances if needed.
Since a `Statement` instance is independent of the CSV document you can re-use it on different CSV
documents or `TabularDataReader` instances if needed.

## FragmentFinder

Expand Down
9 changes: 0 additions & 9 deletions src/AbstractCsvTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
use function xdebug_get_headers;

use const PHP_EOL;
use const PHP_VERSION_ID;

#[Group('csv')]
final class AbstractCsvTest extends TestCase
Expand Down Expand Up @@ -415,10 +414,6 @@ public function testBOMStripping(): void

public function testOutputStripBOM(): void
{
if (PHP_VERSION_ID >= 80300) {
self::markTestSkipped('Issue with PHPUnit in PHP8.3');
}

$raw_csv = ByteSequence::BOM_UTF8."john,doe,[email protected]\njane,doe,[email protected]\n";
$csv = Reader::createFromString($raw_csv);
$csv->setOutputBOM(ByteSequence::BOM_UTF16_BE);
Expand All @@ -434,10 +429,6 @@ public function testOutputStripBOM(): void

public function testOutputDoesNotStripBOM(): void
{
if (PHP_VERSION_ID >= 80300) {
self::markTestSkipped('Issue with PHPUnit in PHP8.3');
}

$raw_csv = ByteSequence::BOM_UTF8."john,doe,[email protected]\njane,doe,[email protected]\n";
$csv = Reader::createFromString($raw_csv);
$csv->setOutputBOM(ByteSequence::BOM_UTF16_BE);
Expand Down

0 comments on commit 91dc8ff

Please sign in to comment.