bug fixing insertOne silently failing

thephpleague · Jul 10, 2017 · 2b023ec · 2b023ec
1 parent 209c92c
commit 2b023ec
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 1 deletion.
diff --git a/.travis.yml b/.travis.yml
@@ -1,6 +1,7 @@
 language: php
 
 sudo: false
+dist: trusty
 
 matrix:
   include:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,26 @@
 
 All Notable changes to `Csv` will be documented in this file
 
+## 8.2.2 - TBD
+
+### Added
+
+- None
+
+### Deprecated
+
+- None
+
+### Fixed
+
+- `Writer::insertOne` was silently failing when inserted record in a CSV document in non-writing mode.
+- bug fix docblock
+
+
+### Removed
+
+- None
+
 ## 8.2.1 - 2017-02-22
 
 ### Added

diff --git a/src/Writer.php b/src/Writer.php
@@ -16,6 +16,7 @@
 use League\Csv\Modifier\RowFilter;
 use League\Csv\Modifier\StreamIterator;
 use ReflectionMethod;
+use RuntimeException;
 use SplFileObject;
 use Traversable;
 
@@ -109,7 +110,10 @@ public function insertOne($row)
     protected function addRow(array $row)
     {
         $this->initCsv();
-        $this->fputcsv->invokeArgs($this->csv, $this->getFputcsvParameters($row));
+        if (!$this->fputcsv->invokeArgs($this->csv, $this->getFputcsvParameters($row))) {
+            throw new RuntimeException('Unable to write record to the CSV document');
+        }
+
         if ("\n" !== $this->newline) {
             $this->csv->fseek(-1, SEEK_CUR);
             $this->csv->fwrite($this->newline, strlen($this->newline));

diff --git a/test/WriterTest.php b/test/WriterTest.php
@@ -66,6 +66,14 @@ public function testFailedSaveWithWrongType()
         $this->csv->insertAll(new stdClass());
     }
 
+    /**
+     * @expectedException RuntimeException
+     */
+    public function testInsertOneThrowsRuntimeException()
+    {
+        Writer::createFromPath('php://temp', 'r')->insertOne(['foo', 'bar']);
+    }
+
     /**
      * @param  $argument
      * @param  $expected

diff --git a/test/data/newline.csv b/test/data/newline.csv
@@ -1,2 +1,4 @@
 1,two,3,"new
 line"
+1,two,3,"new
+line"