Speed up JsonConverter again

thephpleague · Oct 15, 2024 · 249b7f2 · 249b7f2
1 parent bbdabac
commit 249b7f2
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/JsonConverter.php b/src/JsonConverter.php
@@ -454,24 +454,25 @@ public function convert(iterable $records): Iterator
             return;
         }
 
-        $incr = 0;
         $chunk = [];
+        $chunkOffset = 0;
         $offset = 0;
         $current = $iterator->current();
         $iterator->next();
 
         yield $this->start;
 
         while ($iterator->valid()) {
-            if ($incr === $this->chunkSize) {
+            if ($chunkOffset === $this->chunkSize) {
                 yield ($this->jsonEncodeChunk)($chunk).$this->separator;
 
-                $incr = 0;
+                $chunkOffset = 0;
                 $chunk = [];
             }
 
-            $chunk[++$offset] = $current;
-            ++$incr;
+            $chunk[$offset] = $current;
+            ++$chunkOffset;
+            ++$offset;
             $current = $iterator->current();
             $iterator->next();
         }