Review changes from PR

thephpleague · Nov 10, 2024 · b4dbbf0 · b4dbbf0
1 parent dcfc926
commit b4dbbf0
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 27 deletions.
diff --git a/src/Definition/Definition.php b/src/Definition/Definition.php
@@ -67,7 +67,7 @@ class Definition implements ArgumentResolverInterface, DefinitionInterface
      */
     public function __construct(string $id, $concrete = null)
     {
-        $id = Util::normalizeAlias($id);
+        $id = static::normaliseAlias($id);
 
         $concrete = $concrete ?? $id;
         $this->alias    = $id;
@@ -87,7 +87,7 @@ public function hasTag(string $tag): bool
 
     public function setAlias(string $id): DefinitionInterface
     {
-        $id = Util::normalizeAlias($id);
+        $id = static::normaliseAlias($id);
 
         $this->alias = $id;
         return $this;
@@ -239,4 +239,13 @@ protected function invokeMethods(object $instance): object
 
         return $instance;
     }
+
+    public static function normaliseAlias(string $alias): string
+    {
+        if (strpos($alias, '\\') === 0) {
+            return substr($alias, 1);
+        }
+
+        return $alias;
+    }
 }
diff --git a/src/Definition/DefinitionAggregate.php b/src/Definition/DefinitionAggregate.php
@@ -43,7 +43,7 @@ public function addShared(string $id, $definition): DefinitionInterface
 
     public function has(string $id): bool
     {
-        $id = Util::normalizeAlias($id);
+        $id = Definition::normaliseAlias($id);
 
         foreach ($this->getIterator() as $definition) {
             if ($id === $definition->getAlias()) {
@@ -67,7 +67,7 @@ public function hasTag(string $tag): bool
 
     public function getDefinition(string $id): DefinitionInterface
     {
-        $id = Util::normalizeAlias($id);
+        $id = Definition::normaliseAlias($id);
 
         foreach ($this->getIterator() as $definition) {
             if ($id === $definition->getAlias()) {

diff --git a/src/Definition/Util.php b/src/Definition/Util.php
diff --git a/tests/Definition/DefinitionAggregateTest.php b/tests/Definition/DefinitionAggregateTest.php
@@ -229,10 +229,10 @@ public function testAggregateThrowsExceptionWhenCannotResolve(): void
         $aggregate->resolveNew('alias');
     }
 
-    public function testDefinitionPreceedingSlash(): void
+    public function testDefinitionPrecedingSlash(): void
     {
-        $container   = $this->getMockBuilder(Container::class)->getMock();
-        $aggregate   = new DefinitionAggregate();
+        $container = $this->getMockBuilder(Container::class)->getMock();
+        $aggregate = new DefinitionAggregate();
         $aggregate->setContainer($container);
 
         $some_class = "\\League\\Container\\Test\\Asset\\Foo";
@@ -243,10 +243,10 @@ public function testDefinitionPreceedingSlash(): void
         self::assertInstanceOf(Definition::class, $definition);
     }
 
-    public function testGetPreceedingSlash(): void
+    public function testGetPrecedingSlash(): void
     {
-        $container   = $this->getMockBuilder(Container::class)->getMock();
-        $aggregate   = new DefinitionAggregate();
+        $container = $this->getMockBuilder(Container::class)->getMock();
+        $aggregate = new DefinitionAggregate();
         $aggregate->setContainer($container);
 
         $some_class = Foo::class;
@@ -256,4 +256,32 @@ public function testGetPreceedingSlash(): void
 
         self::assertInstanceOf(Definition::class, $definition);
     }
+
+    public function testDefinitionPrecedingSlashSingularQuotes(): void
+    {
+        $container = $this->getMockBuilder(Container::class)->getMock();
+        $aggregate = new DefinitionAggregate();
+        $aggregate->setContainer($container);
+
+        $some_class = '\\League\\Container\\Test\\Asset\\Foo';
+        $aggregate->add($some_class, null);
+
+        $definition = $aggregate->getDefinition(Foo::class);
+
+        self::assertInstanceOf(Definition::class, $definition);
+    }
+
+    public function testGetPrecedingSlashSingularQuote(): void
+    {
+        $container = $this->getMockBuilder(Container::class)->getMock();
+        $aggregate = new DefinitionAggregate();
+        $aggregate->setContainer($container);
+
+        $some_class = Foo::class;
+        $aggregate->add($some_class, null);
+
+        $definition = $aggregate->getDefinition('\\League\\Container\\Test\\Asset\\Foo');
+
+        self::assertInstanceOf(Definition::class, $definition);
+    }
 }