Merge pull request #261 from skilld-labs/php84

PHP 8.4 compatibility

.github/workflows/test.yml

@@ -33,6 +33,8 @@ jobs:
                 include:
                     - php: '8.0'
                       coverage: false
+                    - php: '8.4'
+                      coverage: false
                     - php: '7.2'
                       coverage: false
                       composer-flags: '--prefer-lowest'
@@ -53,7 +55,7 @@ jobs:
 
             - name: "Use PHPUnit 9.3+ on PHP 8"
               run: composer require --no-update --dev phpunit/phpunit:^9.3
-              if: "matrix.php == '8.0'"
+              if: "matrix.php == '8.0' || matrix.php == '8.4'"
 
             - run: composer update --no-progress ${{ matrix.composer-flags }}
 

src/Argument/LiteralArgument.php

@@ -24,7 +24,7 @@ class LiteralArgument implements LiteralArgumentInterface
      */
     protected $value;
 
-    public function __construct($value, string $type = null)
+    public function __construct($value, ?string $type = null)
     {
         if (
             null === $type

src/Container.php

@@ -40,9 +40,9 @@ class Container implements DefinitionContainerInterface
     protected $delegates = [];
 
     public function __construct(
-        DefinitionAggregateInterface $definitions = null,
-        ServiceProviderAggregateInterface $providers = null,
-        InflectorAggregateInterface $inflectors = null
+        ?DefinitionAggregateInterface $definitions = null,
+        ?ServiceProviderAggregateInterface $providers = null,
+        ?InflectorAggregateInterface $inflectors = null
     ) {
         $this->definitions = $definitions ?? new DefinitionAggregate();
         $this->providers   = $providers   ?? new ServiceProviderAggregate();
@@ -153,7 +153,7 @@ public function has($id): bool
         return false;
     }
 
-    public function inflector(string $type, callable $callback = null): InflectorInterface
+    public function inflector(string $type, ?callable $callback = null): InflectorInterface
     {
         return $this->inflectors->add($type, $callback);
     }

src/DefinitionContainerInterface.php

@@ -16,5 +16,5 @@ public function addServiceProvider(ServiceProviderInterface $provider): self;
     public function addShared(string $id, $concrete = null): DefinitionInterface;
     public function extend(string $id): DefinitionInterface;
     public function getNew($id);
-    public function inflector(string $type, callable $callback = null): InflectorInterface;
+    public function inflector(string $type, ?callable $callback = null): InflectorInterface;
 }

src/Inflector/Inflector.php

@@ -33,7 +33,7 @@ class Inflector implements ArgumentResolverInterface, InflectorInterface
      */
     protected $properties = [];
 
-    public function __construct(string $type, callable $callback = null)
+    public function __construct(string $type, ?callable $callback = null)
     {
         $this->type = $type;
         $this->callback = $callback;

src/Inflector/InflectorAggregate.php

@@ -16,7 +16,7 @@ class InflectorAggregate implements InflectorAggregateInterface
      */
     protected $inflectors = [];
 
-    public function add(string $type, callable $callback = null): Inflector
+    public function add(string $type, ?callable $callback = null): Inflector
     {
         $inflector = new Inflector($type, $callback);
         $this->inflectors[] = $inflector;

src/Inflector/InflectorAggregateInterface.php

@@ -9,6 +9,6 @@
 
 interface InflectorAggregateInterface extends ContainerAwareInterface, IteratorAggregate
 {
-    public function add(string $type, callable $callback = null): Inflector;
+    public function add(string $type, ?callable $callback = null): Inflector;
     public function inflect(object $object);
 }

tests/Asset/Baz.php

@@ -6,7 +6,7 @@
 
 class Baz
 {
-    public function __construct(BarInterface $bar = null)
+    public function __construct(?BarInterface $bar = null)
     {
     }
 }

tests/Asset/Foo.php

@@ -12,7 +12,7 @@ class Foo
 
     public static $staticHello;
 
-    public function __construct(Bar $bar = null)
+    public function __construct(?Bar $bar = null)
     {
         $this->bar = $bar;
     }