Merge pull request #909 from thephpleague/fix-inline-parser-engine-wi…

…th-no-parsers

Fix InlineParserEngine error when no inline parsers are set

CHANGELOG.md

@@ -6,6 +6,12 @@ Updates should follow the [Keep a CHANGELOG](https://keepachangelog.com/) princi
 
 ## [Unreleased][unreleased]
 
+## [2.3.5] - 2022-07-29
+
+### Fixed
+
+- Fixed error using `InlineParserEngine` when no inline parsers are registered in the `Environment` (#908)
+
 ## [2.3.4] - 2022-07-17
 
 ### Changed
@@ -488,7 +494,8 @@ No changes were introduced since the previous release.
     - Alternative 1: Use `CommonMarkConverter` or `GithubFlavoredMarkdownConverter` if you don't need to customize the environment
     - Alternative 2: Instantiate a new `Environment` and add the necessary extensions yourself
 
-[unreleased]: https://github.com/thephpleague/commonmark/compare/2.3.4...main
+[unreleased]: https://github.com/thephpleague/commonmark/compare/2.3.5...main
+[2.3.5]: https://github.com/thephpleague/commonmark/compare/2.3.4...2.3.5
 [2.3.4]: https://github.com/thephpleague/commonmark/compare/2.3.3...2.3.4
 [2.3.3]: https://github.com/thephpleague/commonmark/compare/2.3.2...2.3.3
 [2.3.2]: https://github.com/thephpleague/commonmark/compare/2.3.2...main

src/Parser/InlineParserEngine.php

@@ -39,7 +39,7 @@ final class InlineParserEngine implements InlineParserEngineInterface
      * @psalm-var list<array{0: InlineParserInterface, 1: string, 2: bool}>
      * @phpstan-var array<int, array{0: InlineParserInterface, 1: string, 2: bool}>
      */
-    private array $parsers;
+    private array $parsers = [];
 
     public function __construct(EnvironmentInterface $environment, ReferenceMapInterface $referenceMap)
     {

tests/unit/Parser/InlineParserEngineTest.php

@@ -15,6 +15,7 @@
 
 use League\CommonMark\Environment\Environment;
 use League\CommonMark\Node\Block\Paragraph;
+use League\CommonMark\Node\Inline\Text;
 use League\CommonMark\Parser\Inline\InlineParserMatch;
 use League\CommonMark\Parser\InlineParserEngine;
 use League\CommonMark\Reference\ReferenceMap;
@@ -62,4 +63,17 @@ public function testParseWithDifferentPriorityOrder(): void
         $this->assertSame(['lazy'], $adjectiveParser->getMatches());
         $this->assertSame(['quick', 'jumps'], $fiveLetterParser->getMatches());
     }
+
+    public function testParseWithNoInlineParsers(): void
+    {
+        $environment = new Environment();
+        $engine      = new InlineParserEngine($environment, new ReferenceMap());
+        $paragraph   = new Paragraph();
+        $engine->parse('The quick brown fox jumps over the lazy dog', $paragraph);
+
+        $this->assertCount(1, $paragraph->children());
+        $child = $paragraph->firstChild();
+        $this->assertTrue($child instanceof Text);
+        $this->assertSame('The quick brown fox jumps over the lazy dog', $child->getLiteral());
+    }
 }