Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds methods in Progress to return the current value and total … #205

Closed
wants to merge 0 commits into from

Conversation

everton3x
Copy link
Contributor

This PR adds methods in Progress to return the current value and total value of the progress bar.

Tests not included because they are simple access methods to private properties of the class.

Issue #192

@duncan3dc
Copy link
Member

Hi @everton3x unfortunately you've just missed the cutoff for today's release, but I'll look at this in the next couple of weeks and get it merged

@everton3x
Copy link
Contributor Author

Hi @everton3x unfortunately you've just missed the cutoff for today's release, but I'll look at this in the next couple of weeks and get it merged

Ok, no problem @duncan3dc . PR #206 replaces it.

In PR #206

  • PHPUnit tests ok;
  • PHPCS ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants