Cast to bool only if Argument noValue is true

thephpleague · Oct 30, 2024 · b06b9b0 · b06b9b0
1 parent fb1409a
commit b06b9b0
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/Argument/Argument.php b/src/Argument/Argument.php
@@ -263,8 +263,11 @@ public function noValue()
      */
     protected function setNoValue($noValue)
     {
-        $this->setCastTo('bool');
         $this->noValue = (bool) $noValue;
+
+        if ($this->noValue === true) {
+            $this->setCastTo('bool');
+        }
     }
 
     /**

diff --git a/tests/ArgumentTest.php b/tests/ArgumentTest.php
@@ -126,6 +126,19 @@ public function it_casts_to_bool_when_defined_only()
         $this->assertEquals('bool', $argument->castTo());
     }
 
+    /**
+     * @test
+     * @doesNotPerformAssertions
+     */
+    public function it_casts_to_bool_when_defined_only_true()
+    {
+        $argument = Argument::createFromArray('invalid-cast-type', [
+            'noValue' => false,
+        ]);
+
+        $this->assertNotEquals('bool', $argument->castTo());
+    }
+
     /**
      * @test
      * @doesNotPerformAssertions