Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add non-description versions of col_is_pk with schema #199

Closed
wants to merge 2 commits into from
Closed

add non-description versions of col_is_pk with schema #199

wants to merge 2 commits into from

Conversation

chamini2
Copy link

@chamini2 chamini2 commented Apr 3, 2019

No description provided.

@chamini2
Copy link
Author

chamini2 commented Apr 3, 2019

Tests are failing for a strange reason in some environments

@chamini2
Copy link
Author

chamini2 commented Apr 3, 2019

I just realized this has already been done in #178, but I did not use the DEFAULT keyword. Maybe you can take a look here? If this is merged I intend to add more functions' missing variants.

@theory theory requested a review from decibel April 5, 2019 21:01
@nasbyj
Copy link
Collaborator

nasbyj commented Nov 19, 2019

Please merge master and see if that fixes things. Also, please see the test that's failing in #178; we need to ensure that the (table, column) and (table, column, description) variations continue to work without requiring casting.

@nasbyj
Copy link
Collaborator

nasbyj commented Nov 19, 2019

(BTW, if you allow admins to modify your pull request I can try and do the merge for you).

@chamini2
Copy link
Author

Hey @nasbyj, I tried by just rebasing but it seems my PR has issues now. Maybe you can take a look at it. I have the Allow edits from maintainers enabled. I will add you to my repository where the branch is being updated so you can push there.

@theory
Copy link
Owner

theory commented Oct 10, 2021

(BTW, if you allow admins to modify your pull request I can try and do the merge for you).

Is this something you'd still like to do, Jim?

@theory
Copy link
Owner

theory commented May 21, 2022

Merged in 8f4a881, thank you!

@theory theory mentioned this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants