Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing labels #46

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Allow choosing labels #46

merged 1 commit into from
Jul 1, 2021

Conversation

mpierret
Copy link
Contributor

No description provided.

@ivanosevitch
Copy link
Contributor

Hello @mpierret ! je regarde ça avant lundi soir

@ivanosevitch
Copy link
Contributor

Ca a en tous cas l'air de résoudre de façon élégante l'impossibilité de choisir plusieurs colonnes (relevée dans cette issue par exemple : #37)

Copy link
Contributor

@ivanosevitch ivanosevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai testé fonctionnellement en lançant l'appli en local, ça marche bien !
Juste un commentaire, le reste du code est bon.

window.myDiagram.model.linkDataArray = linkDataArray;
vm.loading = false;
});
});
},

retrieveLastBoardAndListChoice() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le nom n'est plus adapté maintenant qu'il y a aussi les labels :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah oui ! c'est modifié :)

@mpierret mpierret force-pushed the allow-choosing-labels branch from ec87552 to 1b8cd8d Compare June 30, 2021 22:01
@ivanosevitch ivanosevitch merged commit ba57507 into master Jul 1, 2021
@ivanosevitch ivanosevitch deleted the allow-choosing-labels branch July 1, 2021 09:35
@ivanosevitch
Copy link
Contributor

C'est en prod !
Merci pour ton addition, n'hésite pas à en faire la pub.

@ivanosevitch
Copy link
Contributor

ivanosevitch commented Jul 2, 2021

@mpierret
Il y a un petit bug si tu as le temps de regarder :)
#37 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants