removed deprecated node-icns in favor of png2icons #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add archive of 2017-2018 version of site to docs
…nd_sim Updated simulation for immigration bonds instead of bail
wgwz
reviewed
Apr 13, 2019
| @@ -5,7 +5,7 @@ | |||
| "main": "main.js", | |||
| "scripts": { | |||
| "start": "electron .", | |||
| "icons": "nicns --in build/logo.png --out build/icon.icns;convert -resize 256x256 build/logo.png build/icon.ico", | |||
| "icons": "png2icons build/logo.png build/icon -icns && convert -resize 256x256 build/logo.png build/icon.ico", | |||
There was a problem hiding this comment.
👋 hi, @davearch. what did you do to test this? i'm going to try running your branch shortly. one thing i've noticed is that the output filename has changed, it seems. previously it was build/icon.icns and now it seems to be build/icon -icns. it's probably intended! i just want to confirm that, that still results in a file called build/icon.icns. this is just an initial thought. will get back to you with more, if i come across anything while running your branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52
I removed node-icns, I had to add && because for some reason it kept giving me an error with the semicolon.