can node-icns dev dependency be removed?

[wgwz]

node-icns seems to deprecated, and unmaintained. any chance we can remove this dependency?

warning [email protected]: Package no longer supported. Contact [email protected] for more info.

[wgwz]

i'm just realizing this is probably just being used to resize an icon.. at least that's the place i've seen it used so far (in package.json). probably not a big deal to keep it if it's just being used for that.

[Artoria2e5]

Yeah. The icns thing is basically windows ico files but for macs.

If we really want to get rid of this build dependency, there are newer nodejs packages like png2icons. Some builds of ImageMagick convert, which we currently use for windows ICOs, also comes with icns support.

[davearch]

Are the changes acceptable for this issue? I am still new to github pull requests so let me know if there is something else I should do.

[wgwz]

hey @davearch, i'm not affiliated with the project in any way, i've only added a few small contributions. but i'd say it's totally acceptable. i opened a MR a while back and had it merged by the developers here. i'm willing to do some code review for you if you'd like, will take a look today.