Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #256 #258

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from
Open

Conversation

edionmelarosa
Copy link

This PR fixed issue #256

Bug replication

  1. Create a new post.
  2. Go to general settings and add a tag(don't select from existing). Issue begin here.
  3. Edit post content. From here, the issue happens. It sends a request to the backend with not updated tags ids. See the example data below.

Screen Shot 2020-05-29 at 11 59 21 PM

Now, in the backend, it checks the existing tag record by id and inserts a new record if no record found. With the data above this process will fail.

PR Solution

This PR fixes it by returning the updated tag records to frontend and update frontend tag lists with the updated tags from the backend.

@lukesnowden
Copy link

composer require themsaid/wink:dev-master#cfd120fb81aa0b3f1cc1b9de8b3e4f5580f7b352 checked and this fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants