Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support updatable dictionaries #1174

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

support updatable dictionaries #1174

wants to merge 15 commits into from

Conversation

StefanVukovic99
Copy link
Member

early draft

@StefanVukovic99 StefanVukovic99 added kind/enhancement The issue or PR is a new feature or request area/dictionary-format The issue or PR is related to dictionary formatting labels Jul 3, 2024
@StefanVukovic99 StefanVukovic99 mentioned this pull request Jul 6, 2024
Merged
@StefanVukovic99 StefanVukovic99 marked this pull request as ready for review July 6, 2024 19:22
@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner July 6, 2024 19:22
@StefanVukovic99
Copy link
Member Author

This pretty much works now. You can try loading this dict:
kty-sq-de.zip
and search for 'Afrika'. The gloss should contain the text (before update). Then, in the dictionaries modal, click Check for Updates. The button should change its text to 1 updates and a blue badge button should appear next to the dictionary in the list. Clicking the badge should prompt you to update the dictionary. Then search Afrika again and it should be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dictionary-format The issue or PR is related to dictionary formatting kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@StefanVukovic99