fix(tutor_permission_denied_template): call die() instead of return to correctly end execution of code #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tutor LMS v2.6.0 merged to master
…o correctly end execution of code
pano9000
changed the title
|
pinging @harunollyo @shewa12 to kindly get a closer look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was previously using to "return" at the end of the function to stop execution of code.
The way the
tutor_permission_denied_templateis used though, returning will not help -> you need to use die() to halt further execution.e.g. you can see that issue here:
https://demo.themeum.com/tutor/dashboard/create-course/?course_ID=7773
The template is from
tutor-pro/frontend-course-builder.php:in there code does two checks, that are supposed to stop printing the course-builder template - however they use the
tutor_permission_denied_templatefunction, which just returns, so execution just goes on, and everything is printed anyways.(e.g. it also therefore prints the "permission denied template" twice, because it is called twice.)
fixes #686