Simplify package.json filtering logic.

Removed redundant filtering of hidden parent directories in ISPPanelPopulator and moved it to the FileManager helper. This centralizes the logic, reduces duplication, and ensures consistent file filtering throughout the codebase.
thelooter · Dec 20, 2024 · baae18e · baae18e
1 parent 01862bf
commit baae18e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ain/kotlin/com/github/warningimhack3r/intellijshadcnplugin/backend/helpers/FileManager.kt b/...ain/kotlin/com/github/warningimhack3r/intellijshadcnplugin/backend/helpers/FileManager.kt
@@ -83,7 +83,9 @@ class FileManager(private val project: Project) {
                 )
             }
         }).filter { file ->
-            !file.path.contains("/node_modules/") && !file.path.contains("/.git/")
+            !file.path.contains("/node_modules/")
+                    && !file.path.contains("/.git/")
+                    && !file.parent.name.startsWith('.')
         }.sortedBy { file ->
             name.toRegex().find(file.path)?.range?.first ?: Int.MAX_VALUE
         }.also {

diff --git a/src/main/kotlin/com/github/warningimhack3r/intellijshadcnplugin/ui/ISPPanelPopulator.kt b/src/main/kotlin/com/github/warningimhack3r/intellijshadcnplugin/ui/ISPPanelPopulator.kt
@@ -23,8 +23,7 @@ class ISPPanelPopulator(private val project: Project) {
         CoroutineScope(SupervisorJob() + Dispatchers.Default).async {
             return@async Pair(
                 SourceScanner.findShadcnImplementation(project),
-                FileManager.getInstance(project).getVirtualFilesByName("package.json")
-                    .filter { !it.parent.name.startsWith('.') }.size
+                FileManager.getInstance(project).getVirtualFilesByName("package.json").size
             )
         }.asCompletableFuture().thenApplyAsync { (source, packageJsonCount) ->
             log.info("Shadcn implementation detected: $source, package.json count: $packageJsonCount")