Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload stage RPMs to new host #420

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Sep 3, 2024

This would accompany our change to where RPMs are hosted -- theforeman/foreman-infra#2118

For staging RPMs, the structure remains the same and nothing but the host will have to change when we are ready.

publish_release_rpms Fixed Show fixed Hide fixed
publish_release_rpms Fixed Show fixed Hide fixed
publish_release_rpms Fixed Show fixed Hide fixed
publish_release_rpms Fixed Show fixed Hide fixed
REPO_PATH="foreman/$VERSION/$PROJECT/$os"
fi

ssh "$USER@$HOST" "$REPO_PATH" "$REPO_PATH" "$OVERWRITE" "$MERGE"

Check notice

Code scanning / shellcheck

Note that, unescaped, this expands on the client side. Note

Note that, unescaped, this expands on the client side.
@ehelms
Copy link
Member Author

ehelms commented Sep 4, 2024

This adds a script to handle publishing of release RPMs from staging that was previously done by Jenkins code and can replace all of it. This is helped by unifying stage and release to the same structure. The code that can be replaced -- https://github.com/theforeman/jenkins-jobs/blob/master/theforeman.org/pipelines/lib/release.groovy

From examining that code and our usage, I think OVERWRITE and MERGE are now redundant and unused because we construct the structure when generating the staging repository and copy staging directly to release. I believe that means we can also simplify this script (https://github.com/theforeman/foreman-infra/pull/2118/files#diff-3e9ef4a756e78bc155bf6740dd575970bbeb6ceb4338f577e6b12723320e0168).

upload_stage_rpms Outdated Show resolved Hide resolved
upload_stage_rpms Outdated Show resolved Hide resolved
publish_release_rpms Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants