Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a build_stage_repository wrapper #360

Closed
wants to merge 1 commit into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 25, 2024

This wraps the logic that is currently in jenkins-jobs. It uses the fact the repository list is already in the settings and then iterates over it.

Currently untested, writing the jenkins-jobs logic that builds on it now.

This wraps the logic that is currently in jenkins-jobs. It uses the fact
the repository list is already in the settings and then iterates over
it.
@ehelms
Copy link
Member

ehelms commented Mar 25, 2024

I'd like you to meet https://github.com/theforeman/theforeman-rel-eng/blob/master/generate_stage_repository :) My plan all along has been to use scripts from this repo (see #291 (comment)) and theforeman/jenkins-jobs#369 is the first update I want to make before proceeding on to more scripts.

@ekohl
Copy link
Member Author

ekohl commented Mar 25, 2024

Somehow I completely missed the existence of that script. I was playing around with reviewing your PR and reason about it.

@ekohl ekohl closed this Mar 25, 2024
@ekohl ekohl deleted the add-build-stage-wrapper branch March 25, 2024 15:47
@ekohl
Copy link
Member Author

ekohl commented Mar 25, 2024

Btw, the naming of generate_stage_repository is IMHO misleading since it's generating multiple repositories, so should be plural instead of singular.

@ehelms
Copy link
Member

ehelms commented Mar 25, 2024

Btw, the naming of generate_stage_repository is IMHO misleading since it's generating multiple repositories, so should be plural instead of singular.

Fair-ish, it could generate one or more repositories! Depends on the definition of OSES :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants