Define the reposync URL in line and fetch modulemd remotely #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Sep 4, 2023
ehelms
force-pushed
the
avoid-reposync-modulemd
branch
from
2f27cc1
to
57fcc34
Compare
ekohl
reviewed
Sep 4, 2023
ehelms
force-pushed
the
avoid-reposync-modulemd
branch
from
57fcc34
to
d3ff21d
Compare
ekohl
reviewed
Sep 5, 2023
This was referenced Sep 5, 2023
ehelms
force-pushed
the
avoid-reposync-modulemd
branch
from
d3ff21d
to
a72af33
Compare
ekohl
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need to carry around a reposync config file and will also nicely match the supplied version. The script still needs the modulemd file stored in foreman-packaging so this fetches that remotely from github.