Drop wait.yml and put waiting code in each respective build type #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing 3.6/3.7/3.8 is expected due to pylint. |
evgeni
reviewed
Oct 29, 2024
evgeni
reviewed
Oct 29, 2024
The logic for how to wait on a task to build across the different build types supported has diverged to the point where a separate file is more confusing than it is helpful in understanding the code logic. Signed-off-by: Eric D. Helms <[email protected]>
ehelms
force-pushed
the
refactor-wait-tasks
branch
from
f6c6746
to
5becf5a
Compare
evgeni
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for how to wait on a task to build across the different build types supported has diverged to the point where a separate file is more confusing than it is helpful in understanding the code logic.