Add Container Image release workflow #389
Conversation
Odilhao
force-pushed
the
push-container
branch
6 times, most recently
from
d223a99
to
a15ff55
Compare
|
@evgeni do we have |
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| schedule: | ||
| - cron: '5 5 * * 0' |
There was a problem hiding this comment.
we have a release workflow, that runs on "tag is pushed" (https://github.com/theforeman/obal/blob/master/.github/workflows/release.yml), any reason not to hook it up there, instead of releasing on each push to master?
There was a problem hiding this comment.
We don't push tags as much as we merge into master, that's why I did not added to this release workflow.
There was a problem hiding this comment.
We could add a new action/job to release new tags after merging to master, not sure how you or @ehelms feels about this.
There was a problem hiding this comment.
I think releasing more often would be a good thing. Not sure if after every commit would be a good thing though.
There was a problem hiding this comment.
We could have a job that runs weekly and do auto-tag/release if we have a commit stashed from the week prior.
There was a problem hiding this comment.
I'd lean more to sumbitting a PR to release. It might be a bit more complicated, but I like the control. If we generalize it, I can see more repos in our org use it
Jaja, it should "just" work. lol, I said it for EVR too |
No description provided.