-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop tito integration #380
base: master
Are you sure you want to change the base?
Conversation
We have moved away from tito and everything runs with direct koji commands now.
- name: 'Register source dir tito argument' | ||
set_fact: | ||
build_package_tito_releaser_args: | ||
- 'source_dir={{ setup_sources_git_checkout_dir }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is dropped, setup_sources_git_checkout_dir
isn't used anywhere anymore. That means the role now just clones a git repository and then never uses it anymore. Is this role now redundant too? setup_sources_git
was introduced in 923d72c but I think this is Pulp 2. https://github.com/pulp/pulp-packaging/blob/master/package_manifest.yaml is the only place I could find that used it.
This was only used for Pulp 2 and can now be dropped.
Now that the git based setup_sources is dropped, there's only specfile. This simplifies the role by including the content from specfile.yml directly in main.yml.
Marking it as draft until then. |
There is still a need, yes, for obal to use tito to interact with rpkg based tooling (rhpkg, fedpkg) to interact with distgit. It's a very minimal segment at this point, just the "obal release" workflow. It shouldn't be too hard to utilize the underlying tools instead in this workflow. |
We have moved away from tito and everything runs with direct koji commands now.
Fixes #294