Allow passing macros to SRPM build #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
force-pushed
the
allow-passing-nightly-githash
branch
from
a47ec7b
to
dcf64d1
Compare
evgeni
reviewed
Oct 23, 2024
| @@ -83,7 +83,7 @@ def fetch_remote_sources(source_location, source_system, sources_dir): | |||
| zip_file.extract(zip_info, sources_dir) | |||
|
|
|||
|
|
|||
| def build_srpm(module, package, base_dir, sources_dir, scl=None): | |||
| def build_srpm(module, package, base_dir, sources_dir, scl=None, macros=None): | |||
There was a problem hiding this comment.
pylint hates this code:
R: 86, 0: Too many arguments (6/5) (too-many-arguments)
R: 86, 0: Too many positional arguments (6/5) (too-many-positional-arguments)
That said, I don't like that check and would probably just disable it globally.
ehelms
force-pushed
the
allow-passing-nightly-githash
branch
from
dcf64d1
to
0362573
Compare
evgeni
approved these changes
Oct 23, 2024
ehelms
force-pushed
the
allow-passing-nightly-githash
branch
from
8fad2ae
to
6d6dd4a
Compare
|
I am running into pylint not being the same across the versions of Python and these two rules not existing on 3.6/3.7/3.8. I don't recall having ever seen a clean way to handle this situation. |
That's "fine". We had pylint failing on 3.6-3.8 python before this change already. As long as 3.9+ is happy, I'd just merge this. |
Signed-off-by: Eric D. Helms <[email protected]>
ehelms
force-pushed
the
allow-passing-nightly-githash
branch
from
6d6dd4a
to
59a446d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #318
This aligns better with any provided macros by the project and allows for passing a nightly macro.