Refactor update #287
Draft
Refactor update #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows where reading the changelog would be used. This change is a draft to start as it needs NPM support added and there may be some opportunities to do parts of this cleaner or with a module.
The general idea is that right now the update command only updates the version and adds a changelog entry but does no updates to the spec file dependencies. This, when updating versions, can miss new requires or updates to dependency versions. This adds running of spec updates for gem packages (NPM to come) based on the template that is either specified on the command line or (ideally) defined in the package_manifest. This also aims towards idempotency for the update command.