Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop tito integration #380

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Drop tito integration #380

wants to merge 3 commits into from

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 23, 2023

We have moved away from tito and everything runs with direct koji commands now.

Fixes #294

We have moved away from tito and everything runs with direct koji
commands now.
- name: 'Register source dir tito argument'
set_fact:
build_package_tito_releaser_args:
- 'source_dir={{ setup_sources_git_checkout_dir }}'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this is dropped, setup_sources_git_checkout_dir isn't used anywhere anymore. That means the role now just clones a git repository and then never uses it anymore. Is this role now redundant too? setup_sources_git was introduced in 923d72c but I think this is Pulp 2. https://github.com/pulp/pulp-packaging/blob/master/package_manifest.yaml is the only place I could find that used it.

This was only used for Pulp 2 and can now be dropped.
Now that the git based setup_sources is dropped, there's only specfile.
This simplifies the role by including the content from specfile.yml
directly in main.yml.
@evgeni
Copy link
Member

evgeni commented Dec 24, 2023

Is that true for brew builds?

Cc @pcreech @Odilhao

@Odilhao
Copy link
Member

Odilhao commented Dec 24, 2023

Is that true for brew builds?

Cc @pcreech @Odilhao

We need tito for brew, ww still don't have a way to use dist-git without tito, the plan is to bring this to obal next year.

@ekohl ekohl marked this pull request as draft January 2, 2024 14:38
@ekohl
Copy link
Member Author

ekohl commented Jan 2, 2024

Marking it as draft until then.

@pcreech
Copy link
Member

pcreech commented Jan 2, 2024

There is still a need, yes, for obal to use tito to interact with rpkg based tooling (rhpkg, fedpkg) to interact with distgit. It's a very minimal segment at this point, just the "obal release" workflow. It shouldn't be too hard to utilize the underlying tools instead in this workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop tito as a dependency
4 participants