Rely on theforeman-rel-eng projects to upload staging #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces simple wrappers around theforeman-rel-eng scripts to do the heavy lifting. The biggest benefit is that more configuration is removed from this repository and pushed into theforeman-rel-eng where it was already anyway.
|
Do you still want to look into this, given #369 is merged? |
|
I've taken these ideas and brought them to #458. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces simple wrappers around theforeman-rel-eng scripts to do the heavy lifting. The biggest benefit is that more configuration is removed from this repository and pushed into theforeman-rel-eng where it was already anyway.
It is an alternative to #369. The biggest difference is using environment variables via native Jenkins to separate out the logic and keep method invocations easier. Right now it collapses two stages into a single stage since they both share the same configuration.
I'll reference this in my review of #369.