Use correct braces in smart-proxy-plugin script #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
approved these changes
Jan 5, 2024
huh… |
|
Layers of templating ... |
|
Shall we just always instal that bundler version? It works fine with ruby3 too… |
Closed
These are variables that are replaced in Jenkins templating, not bash. Fixes: f164a3f ("Use bundler 2.4.22 in ruby 2.7 environments")
ekohl
changed the title
|
I'm unsure about the Foreman plugin testing, but this looks correct for Smart Proxy. For Foreman plugins I'd rather invest time in phasing it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are variables that are replaced in Jenkins templating, not bash.
Fixes: f164a3f ("Use bundler 2.4.22 in ruby 2.7 environments")